dnd: Avoid a crash
authorMatthias Clasen <mclasen@redhat.com>
Sun, 21 Feb 2016 03:43:43 +0000 (22:43 -0500)
committerMatthias Clasen <mclasen@redhat.com>
Sun, 21 Feb 2016 03:43:43 +0000 (22:43 -0500)
gtk_image_definition_new_icon_name ("") returns NULL. Bail
out early in this case to avoid unreffing NULL later.

https://bugzilla.gnome.org/show_bug.cgi?id=762392

gtk/gtkdnd.c

index e00aab28aeb9f12ad3926b3f2f942d225ce2328d..48be48c355c1aec3ddeeec887d5cc352d0b81dae 100644 (file)
@@ -2857,7 +2857,7 @@ gtk_drag_set_icon_name (GdkDragContext *context,
   GtkImageDefinition *def;
 
   g_return_if_fail (GDK_IS_DRAG_CONTEXT (context));
-  g_return_if_fail (icon_name != NULL);
+  g_return_if_fail (icon_name != NULL && icon_name[0] != '\0');
 
   def = gtk_image_definition_new_icon_name (icon_name);
   set_icon_helper (context, def, hot_x, hot_y);